Repository navigation
PHP 8.3 Session issue? #11601
Description
Description
Using PHP 8.2.4 and older with phpMyAdmin 5.2.1 working fine but when i use it with PHP 8.3.0 it gives this php session error
and some times this
I'm not sure if it's a phpMyAdmin issue or a php issue.
PHP Version
PHP 8.3.0alpha3
Operating System
Windows 10
Activity
ndossche commentedon Jul 6, 2023
I can reproduce this. I'll run a bisect.
ndossche commentedon Jul 6, 2023
First bad commit: b3e33be
cc @iluuu1994
Probably, ext/session was relying on some behaviour that got changed in this commit.
iluuu1994 commentedon Jul 6, 2023
Weird. I can't immediately think of how this change could cause such an issue. Are you looking into it? If not I will do so.
ndossche commentedon Jul 6, 2023
@iluuu1994 I'm not checking it out atm, I'm busy with other stuff :)
iluuu1994 commentedon Jul 6, 2023
The problem is that the code doesn't handle the graceful and unwind exit exceptions, I'll check what the best solution is.
usarise commentedon Jul 6, 2023
@iluuu1994 The code executes, but writes broken data to the session
usarise commentedon Jul 6, 2023
A key is written to the session without any value data
iluuu1994 commentedon Jul 6, 2023
@usarise The issue is in my patch (b3e33be). It's missing the handling of some special exceptions that get thrown when you
exit()out of a request. It's catching these when it shouldn't, causing a fatal error and probably not properly closing and writing to the session. I will need to fix that. But thanks for checking. 🙂Fix accidental handling of unwind and gracful exit exceptions
Fix incorrect handling of unwind and graceful exit exceptions