Repository navigation
get_object_vars leaks class in property when used for class with property getter #16725
Description
Description
The following code:
<?php
class Example implements JsonSerializable
{
public function __construct(
private array $authors,
) {}
public string $credits {
get {
return implode(', ', $this->authors);
}
}
public function jsonSerialize():mixed{
return get_object_vars($this);
}
}
$obj = new Example(['test', 'test2']);
echo json_encode($obj);
Resulted in this output:
{"\u0000Example\u0000authors":["test","test2"],"credits":"test, test2"}
But I expected this output instead:
{"authors":["test","test2"],"credits":"test, test2"}
Without the getter it does serialize as expected:
The following code:
<?php
class Example implements JsonSerializable
{
public function __construct(
private array $authors,
) {}
public function jsonSerialize(): mixed
{
return get_object_vars($this);
}
}Results in
{"authors":["test","test2"]}
PHP Version
master
Operating System
No response
Activity
cmb69 commentedon Nov 8, 2024
serialize()yields (so this is an engine issue, not JSON specific.
ndossche commentedon Nov 8, 2024
get_object_varswill callzho_build_properties_exwhich normally uses the mangled names as keys.[-]json_encode leaks class in property when get_object_vars is used in jsonSerialize with property getter[/-][+]``get_object_vars`` leaks class in property when get_object_vars used in class with property getter[/+]gielwijgergangs commentedon Nov 9, 2024
@cmb69 you are right. The issue is not related to JSON, apologies for the confusion. I modified the title of the issue.
[-]``get_object_vars`` leaks class in property when get_object_vars used in class with property getter[/-][+]``get_object_vars`` leaks class in property when used for class with property getter[/+]cmb69 commentedon Nov 9, 2024
Maybe @iluuu1994 can have a look?
Fix get_object_vars() for non-hooked props in hooked prop iter