Add debug information to cache results#1015
Merged
AJenbo merged 20 commits intoJul 25, 2023
Merged
Conversation
…on-to-cache-results
Codecov ReportPatch coverage:
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. Additional details and impacted files@@ Coverage Diff @@
## master #1015 +/- ##
============================================
+ Coverage 89.10% 89.26% +0.15%
- Complexity 1160 1179 +19
============================================
Files 107 109 +2
Lines 2956 3027 +71
============================================
+ Hits 2634 2702 +68
- Misses 322 325 +3
☔ View full report in Codecov by Sentry. |
kylekatarnls
previously approved these changes
Jul 2, 2023
kylekatarnls
approved these changes
Jul 2, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type: feature
Issue: -
Breaking change: no
Addendum to #1011
I found the lack information of the cache difficult to debug. There's no information presented regarding if the cache is used, which it is read from, or if the cache is still valid. I added a few cli flags to show more information:
Feature
-v, -vv, -vvv. Which increments the verbosity of the output. Default is 'Normal'.-v,-vv, or-vvvis specified, the behaviour is currently as it is now and nothing is printed.Changes
OutputInterfacebased on Symfony's Console package. Should be drop-in replacement if at some point Symfony Console can/will be used.NullOutput(for tests) andStreamOutputclasses to be able to write output with verbosity level.Quiet,Normal(default),Verbose,VeryVerboseandDebug. Currently onlyVeryVerboseandDebugis being written to.Note, this branch contains the changes from PR 1011. I don't seem to be able to target that PR in this PR.