Skip to content

Add /admin -> /admin/ redirect handler#1668

Merged
DL6ER merged 1 commit into
development-v6from
fix/redirect_admin_slash
Oct 16, 2023
Merged

Add /admin -> /admin/ redirect handler#1668
DL6ER merged 1 commit into
development-v6from
fix/redirect_admin_slash

Conversation

@DL6ER

@DL6ER DL6ER commented Oct 16, 2023

Copy link
Copy Markdown
Member

What does this implement/fix?

Add /admin -> /admin/ redirect handler (mind the trailing slash). This will fix pi-hole/web#2753

Related issue or feature (if applicable): N/A

Pull request in docs with documentation (if applicable): N/A


By submitting this pull request, I confirm the following:

  1. I have read and understood the contributors guide, as well as this entire template. I understand which branch to base my commits and Pull Requests against.
  2. I have commented my proposed changes within the code.
  3. I am willing to help maintain this change if there are issues with it later.
  4. It is compatible with the EUPL 1.2 license
  5. I have squashed any insignificant commits. (git rebase)

Checklist:

  • The code change is tested and works locally.
  • I based my code and PRs against the repositories developmental branch.
  • I signed off all commits. Pi-hole enforces the DCO for all contributions
  • I signed all my commits. Pi-hole requires signatures to verify authorship
  • I have read the above and my PR is ready for review.

Signed-off-by: DL6ER <dl6er@dl6er.de>
@DL6ER DL6ER requested a review from a team October 16, 2023 14:45
@pralor-bot

Copy link
Copy Markdown

This pull request has been mentioned on Pi-hole Userspace. There might be relevant details there:

https://discourse.pi-hole.net/t/urls-on-dashboard-give-a-404/65631/5

@pralor-bot

Copy link
Copy Markdown

This pull request has been mentioned on Pi-hole Userspace. There might be relevant details there:

https://discourse.pi-hole.net/t/bug-404-error-when-clicking-bar-chart-in-total-queries/65651/2

@DL6ER DL6ER merged commit 3502be0 into development-v6 Oct 16, 2023
@DL6ER DL6ER deleted the fix/redirect_admin_slash branch October 16, 2023 21:21
@PromoFaux PromoFaux mentioned this pull request Feb 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

/admin > /admin/ redirect not working for Dashboard header links

3 participants