Fix regression of #1667#1680
Merged
Merged
Conversation
…-z0-9_-]{0,63}\\.), move the corresponding tests to a concluding TLD check region (pattern [a-z0-9][a-z0-9-]{0,61}[a-z0-9])
Signed-off-by: DL6ER <dl6er@dl6er.de>
|
This pull request has been mentioned on Pi-hole Userspace. There might be relevant details there: https://discourse.pi-hole.net/t/gravity-domain-filtering-different/65726/4 |
PromoFaux
approved these changes
Oct 20, 2023
PromoFaux
left a comment
Member
There was a problem hiding this comment.
Tested against the blocklist in use for the initial but report and confirm that the issue is no longer present
[i] Target: https://raw.githubusercontent.com/chadmayfield/my-pihole-blocklists/master/lists/pi_blocklist_porn_all.list
[✓] Status: Retrieval successful
[✓] Parsed 1906594 exact domains and 0 ABP-style domains (blocking, ignored 0 non-domain entries)
[i] List stayed unchanged
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this implement/fix?
Subdomains beginning and ending in dash are actually fine (pattern
[a-z0-9_-]{0,63}\.), move the corresponding tests to a concluding TLD check region (pattern[a-z0-9][a-z0-9-]{0,61}[a-z0-9])Related issue or feature (if applicable): N/A
Pull request in docs with documentation (if applicable): N/A
By submitting this pull request, I confirm the following:
git rebase)Checklist:
developmentalbranch.