Skip to content

Use UPSERT instead of special REPLACE INTO statements to update exist…#1695

Merged
DL6ER merged 1 commit into
development-v6from
tweak/optimize_list_manipulation
Oct 26, 2023
Merged

Use UPSERT instead of special REPLACE INTO statements to update exist…#1695
DL6ER merged 1 commit into
development-v6from
tweak/optimize_list_manipulation

Conversation

@DL6ER

@DL6ER DL6ER commented Oct 23, 2023

Copy link
Copy Markdown
Member

What does this implement/fix?

Use UPSERT instead of our specially crafted REPLACE INTO statements to update existing group, adlist, domainlist, and client rows in the gravity database. This effectively avoids foreign key violation checks, fixing #1692

Related issue or feature (if applicable): N/A

Pull request in docs with documentation (if applicable): N/A


By submitting this pull request, I confirm the following:

  1. I have read and understood the contributors guide, as well as this entire template. I understand which branch to base my commits and Pull Requests against.
  2. I have commented my proposed changes within the code.
  3. I am willing to help maintain this change if there are issues with it later.
  4. It is compatible with the EUPL 1.2 license
  5. I have squashed any insignificant commits. (git rebase)

Checklist:

  • The code change is tested and works locally.
  • I based my code and PRs against the repositories developmental branch.
  • I signed off all commits. Pi-hole enforces the DCO for all contributions
  • I signed all my commits. Pi-hole requires signatures to verify authorship
  • I have read the above and my PR is ready for review.

…ing group, adlist, domainlist, and client rows in the gravity database

Signed-off-by: DL6ER <dl6er@dl6er.de>
@DL6ER DL6ER merged commit fab6865 into development-v6 Oct 26, 2023
@DL6ER DL6ER deleted the tweak/optimize_list_manipulation branch October 26, 2023 15:06
@DL6ER DL6ER mentioned this pull request Nov 10, 2023
5 tasks
@PromoFaux PromoFaux mentioned this pull request Feb 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants