Improve FTL's file comparsion algorithm#1785
Merged
Merged
Conversation
…le comparison (debug.config) Signed-off-by: DL6ER <dl6er@dl6er.de>
|
This pull request has been mentioned on Pi-hole Userspace. There might be relevant details there: https://discourse.pi-hole.net/t/local-dns-records-not-resolving/66521/14 |
Member
Author
|
Bugfix confirmed working by OP on Discourse. The key issue we solve here was that |
yubiuser
reviewed
Nov 28, 2023
yubiuser
approved these changes
Nov 30, 2023
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this implement/fix?
Fix file comparison and add more debug logging during file comparison. So far, this should not have any negative consequences as all files we apply this function on will always differ somewhere before the end of the files when they are different (
custom.listhas the total number of lines on the end,dnsmasq.confandpihole.tomlhave no multi-line options at the end).Related issue or feature (if applicable): N/A
Pull request in docs with documentation (if applicable): N/A
By submitting this pull request, I confirm the following:
git rebase)Checklist:
developmentalbranch.