Ensure %used is 0.0 if no swap is used#1717
Merged
Merged
Conversation
Signed-off-by: DL6ER <dl6er@dl6er.de>
Member
Author
|
I did just verify that this branch compiles fine without warnings on said system without swap memory. |
yubiuser
approved these changes
Oct 31, 2023
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this implement/fix?
When test compiling FTL on a machine without swap, we've seen the following result in the tests:
This is caused by a division-by-zero error which lead to a
nullbeing returned in the JSON. There are two obvious fixes:nullhere, or0is returned instead (0% swap used).The latter seems superior as it needs less logic on the client side to handle this.
Even when we will never see a system with no RAM, the logic is applied here as well - just as a precaution because division-by-zero is never a good thing.
Related issue or feature (if applicable): N/A
Pull request in docs with documentation (if applicable): N/A
By submitting this pull request, I confirm the following:
git rebase)Checklist:
developmentalbranch.