Skip to content

Improve config migration logging#1891

Merged
DL6ER merged 1 commit into
development-v6from
fix/migration_message
Mar 4, 2024
Merged

Improve config migration logging#1891
DL6ER merged 1 commit into
development-v6from
fix/migration_message

Conversation

@DL6ER

@DL6ER DL6ER commented Feb 17, 2024

Copy link
Copy Markdown
Member

What does this implement/fix?

No functional change This PR addresses a message which unnecessarily concerned a user in the related Discourse thread. We solve this by not logging this message unless debug.config = true is explicitly set. There is no issue at all when this message appears. It simply means the config wasn't old - as the old item wasn't there, it didn't need migration.

While I was at it, I expanded the comments around this code to make clear what the code does and why it may reach one or the other place.


Related issue or feature (if applicable): see link above

Pull request in docs with documentation (if applicable): N/A


By submitting this pull request, I confirm the following:

  1. I have read and understood the contributors guide, as well as this entire template. I understand which branch to base my commits and Pull Requests against.
  2. I have commented my proposed changes within the code.
  3. I am willing to help maintain this change if there are issues with it later.
  4. It is compatible with the EUPL 1.2 license
  5. I have squashed any insignificant commits. (git rebase)

Checklist:

  • The code change is tested and works locally.
  • I based my code and PRs against the repositories developmental branch.
  • I signed off all commits. Pi-hole enforces the DCO for all contributions
  • I signed all my commits. Pi-hole requires signatures to verify authorship
  • I have read the above and my PR is ready for review.

Signed-off-by: DL6ER <dl6er@dl6er.de>
@DL6ER DL6ER requested a review from a team February 17, 2024 15:27
@pralor-bot

Copy link
Copy Markdown

This pull request has been mentioned on Pi-hole Userspace. There might be relevant details there:

https://discourse.pi-hole.net/t/pihole-v6-update-seems-to-break-my-install/68376/5

@DL6ER DL6ER removed the request for review from a team February 17, 2024 16:26
@DL6ER DL6ER marked this pull request as draft February 17, 2024 16:26
@DL6ER DL6ER marked this pull request as ready for review February 17, 2024 18:13
@DL6ER DL6ER requested a review from a team February 17, 2024 18:13
@DL6ER DL6ER merged commit 93d01d9 into development-v6 Mar 4, 2024
@DL6ER DL6ER deleted the fix/migration_message branch March 4, 2024 18:41
@PromoFaux PromoFaux mentioned this pull request Feb 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants