Implement special POST :batchDelete callbacks#1810
Merged
Conversation
…omains/, /api/clients, and /api/lists Signed-off-by: DL6ER <dl6er@dl6er.de>
5 tasks
|
This pull request has been mentioned on Pi-hole Userspace. There might be relevant details there: |
rdwebdesign
approved these changes
Dec 15, 2023
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this implement/fix?
This PR implements new special
POST :batchDeletecallbacks for/api/groups,/api/domains,/api/clients, and/api/lists. While not being immediately obvious, this is actually acceptable in the REST-world, see e.g., Custom methods | Cloud APIs | Google Cloud for a similar implementation.While batch-deletion could indeed by very simple in the sense of
this is unfortunately not possible with SQLite3 as the
IN ()operator lacks support for binding variables. So I ended up implementing the following workaround that uses parameter binding to eliminate any possibility of SQL injections:TEMPORARYtable (lives only in memory) calleddeltableINSERTeach row into this table (values are bound to the table)If anything fails, we
ROLLBACKto undo anything. Surely this SQL will not win a beauty contest due to the involved subqueries but they are so fast and their results are so small that I couldn't be bothered to useJOINinstead.Addendum:
It is actually more tricky for domains as they are identified in addition by a
type, so their temporary database is(item, type)and the SQL looks like:This PR should still work fine with
webon branchdevelopment-v6which does not use:batchDelete. However, to really get the speed benefits, you'll really need to switchwebto the accompanying branch (it has the same name). This ensures that your deletions - regardless how many things you delete - will all be done at once.Related issue or feature (if applicable): N/A
Pull request in docs with documentation (if applicable): N/A
By submitting this pull request, I confirm the following:
git rebase)Checklist:
developmentalbranch.