Fix spilled queries in database#1960
Merged
Merged
Conversation
… of arbitrary size and frequency Signed-off-by: DL6ER <dl6er@dl6er.de>
Signed-off-by: DL6ER <dl6er@dl6er.de>
|
This pull request has been mentioned on Pi-hole Userspace. There might be relevant details there: https://discourse.pi-hole.net/t/discrepancy-between-pi-hole-api-client-query-count-and-logs/70065/17 |
Member
Author
|
Confirmed working by letting this run locally for 2 days by now and independent confirmation by OP on Discourse: https://discourse.pi-hole.net/t/discrepancy-between-pi-hole-api-client-query-count-and-logs/70065/19 |
dschaper
approved these changes
May 15, 2024
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this implement/fix?
Improve query storing algorithm to better cope with bursts of queries of arbitrary size and frequency. See related Discourse bug chasing for further details.
This is overall an improvement as the new strategy guarantees that no queries can be lost on one hand and drastically reduces the workload on the other hand by using persistent prepared statements instead of compiling them once per second.
Related issue or feature (if applicable): N/A
Pull request in docs with documentation (if applicable): N/A
By submitting this pull request, I confirm the following:
git rebase)Checklist:
developmentalbranch.