Skip to content

Add new dhcp.logging option#1918

Merged
DL6ER merged 1 commit into
development-v6from
new/log-dhcp
Mar 26, 2024
Merged

Add new dhcp.logging option#1918
DL6ER merged 1 commit into
development-v6from
new/log-dhcp

Conversation

@DL6ER

@DL6ER DL6ER commented Mar 24, 2024

Copy link
Copy Markdown
Member

What does this implement/fix?

See title. Relevant for debugging/tracing down DHCP issues with a much lower entrance barrier compared to running Wireshark capturing on a remote device (when your Pi-hole is a headless system).

This option default to false and be activated as any other config option, too, via

  • the API, or
  • the CLI (like sudo pihole-FTL --config dhcp.logging true), or
  • direct interaction with /etc/pihole/pihole.toml, or
  • by importing a teleporter file where this is already active.

Related issue or feature (if applicable): See Discourse thread mentioned below.

Pull request in docs with documentation (if applicable): N/A


By submitting this pull request, I confirm the following:

  1. I have read and understood the contributors guide, as well as this entire template. I understand which branch to base my commits and Pull Requests against.
  2. I have commented my proposed changes within the code.
  3. I am willing to help maintain this change if there are issues with it later.
  4. It is compatible with the EUPL 1.2 license
  5. I have squashed any insignificant commits. (git rebase)

Checklist:

  • The code change is tested and works locally.
  • I based my code and PRs against the repositories developmental branch.
  • I signed off all commits. Pi-hole enforces the DCO for all contributions
  • I signed all my commits. Pi-hole requires signatures to verify authorship
  • I have read the above and my PR is ready for review.

Signed-off-by: DL6ER <dl6er@dl6er.de>
@pralor-bot

Copy link
Copy Markdown

This pull request has been mentioned on Pi-hole Userspace. There might be relevant details there:

https://discourse.pi-hole.net/t/host-name-of-client-xxx-contains-at-least-one-invalid-character-at-position-0/69132/12

@DL6ER DL6ER merged commit 63571bb into development-v6 Mar 26, 2024
@DL6ER DL6ER deleted the new/log-dhcp branch March 26, 2024 19:51
@pralor-bot

Copy link
Copy Markdown

This pull request has been mentioned on Pi-hole Userspace. There might be relevant details there:

https://discourse.pi-hole.net/t/host-name-of-client-xxx-contains-at-least-one-invalid-character-at-position-0/69132/21

@PromoFaux PromoFaux mentioned this pull request Feb 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants