Add new dhcp.logging option#1918
Merged
Merged
Conversation
Signed-off-by: DL6ER <dl6er@dl6er.de>
|
This pull request has been mentioned on Pi-hole Userspace. There might be relevant details there: |
dschaper
approved these changes
Mar 26, 2024
|
This pull request has been mentioned on Pi-hole Userspace. There might be relevant details there: |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this implement/fix?
See title. Relevant for debugging/tracing down DHCP issues with a much lower entrance barrier compared to running Wireshark capturing on a remote device (when your Pi-hole is a headless system).
This option default to
falseand be activated as any other config option, too, viasudo pihole-FTL --config dhcp.logging true), or/etc/pihole/pihole.toml, orRelated issue or feature (if applicable): See Discourse thread mentioned below.
Pull request in docs with documentation (if applicable): N/A
By submitting this pull request, I confirm the following:
git rebase)Checklist:
developmentalbranch.