Skip to content

Do not overwrite externally given MAKEFLAGS if set#2360

Merged
DL6ER merged 1 commit into
developmentfrom
tweak/buildsh
Mar 10, 2025
Merged

Do not overwrite externally given MAKEFLAGS if set#2360
DL6ER merged 1 commit into
developmentfrom
tweak/buildsh

Conversation

@DL6ER

@DL6ER DL6ER commented Mar 8, 2025

Copy link
Copy Markdown
Member

What does this implement/fix?

A very simple change, see #2358 for more context.


Related issue or feature (if applicable): Fixes #2358

Pull request in docs with documentation (if applicable): N/A


By submitting this pull request, I confirm the following:

  1. I have read and understood the contributors guide, as well as this entire template. I understand which branch to base my commits and Pull Requests against.
  2. I have commented my proposed changes within the code.
  3. I am willing to help maintain this change if there are issues with it later.
  4. It is compatible with the EUPL 1.2 license
  5. I have squashed any insignificant commits. (git rebase)

Checklist:

  • The code change is tested and works locally.
  • I based my code and PRs against the repositories developmental branch.
  • I signed off all commits. Pi-hole enforces the DCO for all contributions
  • I signed all my commits. Pi-hole requires signatures to verify authorship
  • I have read the above and my PR is ready for review.

@DL6ER DL6ER added the CI label Mar 8, 2025
Comment thread build.sh Outdated
Signed-off-by: DL6ER <dl6er@dl6er.de>
@DL6ER DL6ER requested a review from yubiuser March 9, 2025 19:03
@DL6ER DL6ER marked this pull request as ready for review March 9, 2025 19:03
@DL6ER DL6ER merged commit bb3e22f into development Mar 10, 2025
@DL6ER DL6ER deleted the tweak/buildsh branch March 10, 2025 18:49
@PromoFaux PromoFaux mentioned this pull request Mar 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants