Skip to content

Fix signedness error in the NTP total round-trip delay calculation#2420

Merged
DL6ER merged 1 commit into
developmentfrom
fix/ntp_negative_root_delay
Apr 6, 2025
Merged

Fix signedness error in the NTP total round-trip delay calculation#2420
DL6ER merged 1 commit into
developmentfrom
fix/ntp_negative_root_delay

Conversation

@DL6ER

@DL6ER DL6ER commented Apr 6, 2025

Copy link
Copy Markdown
Member

What does this implement/fix?

Fix un-/signed error in the total round-trip delay to the reference clock stemming from an unclear definition in RFC 5905


Related issue or feature (if applicable): Fixes #2418

Pull request in docs with documentation (if applicable): N/A


By submitting this pull request, I confirm the following:

  1. I have read and understood the contributors guide, as well as this entire template. I understand which branch to base my commits and Pull Requests against.
  2. I have commented my proposed changes within the code.
  3. I am willing to help maintain this change if there are issues with it later.
  4. It is compatible with the EUPL 1.2 license
  5. I have squashed any insignificant commits. (git rebase)

Checklist:

  • The code change is tested and works locally.
  • I based my code and PRs against the repositories developmental branch.
  • I signed off all commits. Pi-hole enforces the DCO for all contributions
  • I signed all my commits. Pi-hole requires signatures to verify authorship
  • I have read the above and my PR is ready for review.

…lock steming from an unclear definition in RFC 5905

Signed-off-by: DL6ER <dl6er@dl6er.de>
@DL6ER DL6ER merged commit 12704b8 into development Apr 6, 2025
@DL6ER DL6ER deleted the fix/ntp_negative_root_delay branch April 6, 2025 19:01
@PromoFaux PromoFaux mentioned this pull request May 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants