Skip to content

fix: change type of disk parameter for GET /queries#2589

Merged
DL6ER merged 1 commit into
pi-hole:developmentfrom
ninjack-dev:patch-1
Jul 30, 2025
Merged

fix: change type of disk parameter for GET /queries#2589
DL6ER merged 1 commit into
pi-hole:developmentfrom
ninjack-dev:patch-1

Conversation

@ninjack-dev

@ninjack-dev ninjack-dev commented Jul 30, 2025

Copy link
Copy Markdown
Contributor

What does this PR aim to accomplish?:
Resolves #2546. In short, it fixes the type of the disk parameter for GET /queries, which was originally a true/false enum type instead of a boolean.


  1. I have read and understood the contributors guide, as well as this entire template. I understand which branch to base my commits and Pull Requests against.
  2. I have commented my proposed changes within the code and I have tested my changes.
  3. I am willing to help maintain this change if there are issues with it later.
  4. It is compatible with the EUPL 1.2 license
  5. I have squashed any insignificant commits. (git rebase)
  6. I have checked that another pull request for this purpose does not exist.
  7. I have considered, and confirmed that this submission will be valuable to others.
  8. I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
  9. I give this submission freely, and claim no ownership to its content.

  • I have read the above and my PR is ready for review.

Signed-off-by: Ninjackson <84806918+ninjack-dev@users.noreply.github.com>
@ninjack-dev ninjack-dev requested a review from a team as a code owner July 30, 2025 19:52
@DL6ER DL6ER enabled auto-merge July 30, 2025 20:00
@DL6ER DL6ER merged commit cee2566 into pi-hole:development Jul 30, 2025
12 checks passed
@ninjack-dev ninjack-dev deleted the patch-1 branch July 30, 2025 21:12
@PromoFaux PromoFaux mentioned this pull request Oct 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants