Skip to content

Fix dns.interface comment#2597

Merged
DL6ER merged 3 commits into
developmentfrom
fix/interface_comment
Aug 12, 2025
Merged

Fix dns.interface comment#2597
DL6ER merged 3 commits into
developmentfrom
fix/interface_comment

Conversation

@rdwebdesign

Copy link
Copy Markdown
Member

What does this PR aim to accomplish?

Replace a comment suggesting the old dnsmasq.listening.mode option with the correct dns.listeningMode.


By submitting this pull request, I confirm the following:

  1. I have read and understood the contributors guide, as well as this entire template. I understand which branch to base my commits and Pull Requests against.
  2. I have commented my proposed changes within the code and I have tested my changes.
  3. I am willing to help maintain this change if there are issues with it later.
  4. It is compatible with the EUPL 1.2 license
  5. I have squashed any insignificant commits. (git rebase)
  6. I have checked that another pull request for this purpose does not exist.
  7. I have considered, and confirmed that this submission will be valuable to others.
  8. I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
  9. I give this submission freely, and claim no ownership to its content.

  • I have read the above and my PR is ready for review. Check this box to confirm

Replace a comment suggesting the old `dnsmasq.listening.mode` option with the correct `dns.listeningMode`.

Signed-off-by: RD WebDesign <github@rdwebdesign.com.br>
@rdwebdesign rdwebdesign requested a review from a team as a code owner August 10, 2025 21:31
yubiuser
yubiuser previously approved these changes Aug 11, 2025
@rdwebdesign

Copy link
Copy Markdown
Member Author

I forgot the pihole.toml...

Signed-off-by: RD WebDesign <github@rdwebdesign.com.br>
Comment thread test/pihole.toml Outdated
Signed-off-by: Dominik <DL6ER@users.noreply.github.com>
@DL6ER DL6ER merged commit 3a15d94 into development Aug 12, 2025
17 of 18 checks passed
@DL6ER DL6ER deleted the fix/interface_comment branch August 12, 2025 19:35
@PromoFaux PromoFaux mentioned this pull request Oct 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants