Fix database busy handler initialization#2646
Merged
Merged
Conversation
…the wrong database Signed-off-by: Dominik <dl6er@dl6er.de>
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a copy-paste error in the database busy handler initialization where the wrong database handle was being used. The fix ensures the busy handler is properly set for the correct database connection.
- Corrects database handle reference in
sqlite3_busy_handlercall - Addresses a regression introduced in a recent pull request (#2602)
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Member
Author
It just happened to set the busy handler for the other database. There is no error expected. The entirety of busy handlers is not really needed during normal FTL operation. It only comes into play when external user scripts keep the database locked in ways not initiated by FTL itself. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this implement/fix?
Fix a small copy-pate error where we're setting the busy handler for the wrong database
This is a recent regression from #2602
Related issue or feature (if applicable): N/A
Pull request in docs with documentation (if applicable): N/A
By submitting this pull request, I confirm the following:
git rebase)Checklist:
developmentbranch.