Skip to content

[Meta] Attach binaries to the correct release#2663

Merged
PromoFaux merged 1 commit into
developmentfrom
binary-attachment
Oct 26, 2025
Merged

[Meta] Attach binaries to the correct release#2663
PromoFaux merged 1 commit into
developmentfrom
binary-attachment

Conversation

@PromoFaux

Copy link
Copy Markdown
Member

What does this PR aim to accomplish?:

This should solve the issue we saw yesterday where the action did not attach the binaries to the correct release/tag object


By submitting this pull request, I confirm the following:

  1. I have read and understood the contributors guide, as well as this entire template. I understand which branch to base my commits and Pull Requests against.
  2. I have commented my proposed changes within the code and I have tested my changes.
  3. I am willing to help maintain this change if there are issues with it later.
  4. It is compatible with the EUPL 1.2 license
  5. I have squashed any insignificant commits. (git rebase)

  • I have read the above and my PR is ready for review. Check this box to confirm

Signed-off-by: Adam Warner <me@adamwarner.co.uk>
@PromoFaux PromoFaux requested a review from a team as a code owner October 26, 2025 14:14

@yubiuser yubiuser left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it does not work, we can still attach manually.

@PromoFaux

Copy link
Copy Markdown
Member Author

Exactly!

@PromoFaux PromoFaux merged commit 53b98ec into development Oct 26, 2025
17 checks passed
@PromoFaux PromoFaux deleted the binary-attachment branch October 26, 2025 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants