Skip to content

fix OOB write in FTL_parse_pseudoheaders when optlen is 0#2910

Merged
DL6ER merged 1 commit into
pi-hole:developmentfrom
rdevshp:edns0_optlen0_fix
Jun 13, 2026
Merged

fix OOB write in FTL_parse_pseudoheaders when optlen is 0#2910
DL6ER merged 1 commit into
pi-hole:developmentfrom
rdevshp:edns0_optlen0_fix

Conversation

@rdevshp

@rdevshp rdevshp commented Jun 10, 2026

Copy link
Copy Markdown

Thank you for your contribution to the Pi-hole Community!

Please read the comments below to help us consider your Pull Request.

We are all volunteers and completing the process outlined will help us review your commits quicker.

Please make sure you

  1. Base your code and PRs against the repositories developmental branch.
  2. Sign Off all commits as we enforce the DCO for all contributions
  3. Sign all your commits as they must have verified signatures
  4. File a pull request for any change that requires changes to our documentation at our documentation repo

What does this PR aim to accomplish?:

Fix OOB write in FTL_parse_pseudoheaders when optlen is 0


By submitting this pull request, I confirm the following:

  1. I have read and understood the contributors guide, as well as this entire template. I understand which branch to base my commits and Pull Requests against.
  2. I have commented my proposed changes within the code and I have tested my changes.
  3. I am willing to help maintain this change if there are issues with it later.
  4. It is compatible with the EUPL 1.2 license
  5. I have squashed any insignificant commits. (git rebase)
  6. I have checked that another pull request for this purpose does not exist.
  7. I have considered, and confirmed that this submission will be valuable to others.
  8. I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
  9. I give this submission freely, and claim no ownership to its content.

  • [ x ] I have read the above and my PR is ready for review. Check this box to confirm

@rdevshp rdevshp requested a review from a team as a code owner June 10, 2026 10:45
Comment thread src/edns0.c Outdated
Signed-off-by: rdevshp <rdevshp@gmail.com>
@rdevshp rdevshp force-pushed the edns0_optlen0_fix branch from 1c761f9 to a0238d9 Compare June 12, 2026 16:17
@rdevshp rdevshp requested a review from DL6ER June 12, 2026 16:18
@DL6ER

DL6ER commented Jun 13, 2026

Copy link
Copy Markdown
Member

Thank you!

@DL6ER DL6ER merged commit 6ef7e94 into pi-hole:development Jun 13, 2026
13 checks passed
@rdevshp rdevshp deleted the edns0_optlen0_fix branch June 13, 2026 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants