Skip to content

Fix check of ticked non-custom DNS servers#2640

Merged
PromoFaux merged 1 commit into
development-v6from
fix/dns_servers
Jul 18, 2023
Merged

Fix check of ticked non-custom DNS servers#2640
PromoFaux merged 1 commit into
development-v6from
fix/dns_servers

Conversation

@DL6ER

@DL6ER DL6ER commented Jul 18, 2023

Copy link
Copy Markdown
Member

Thank you for your contribution to the Pi-hole Community!

Please read the comments below to help us consider your Pull Request.

We are all volunteers and completing the process outlined will help us review your commits quicker.

Please make sure you

  1. Base your code and PRs against the repositories developmental branch.
  2. Sign Off all commits as we enforce the DCO for all contributions
  3. Sign all your commits as they must have verified signatures
  4. File a pull request for any change that requires changes to our documentation at our documentation repo

What does this PR aim to accomplish?:

See title

How does this PR accomplish the above?:

Acknowledge that a in b is not working to check for the presence of strings in arrays in Javascript. Instead, we have to use the more verbose syntax b.includes(a).

Link documentation PRs if any are needed to support this PR:

None


By submitting this pull request, I confirm the following:

  1. I have read and understood the contributors guide, as well as this entire template. I understand which branch to base my commits and Pull Requests against.
  2. I have commented my proposed changes within the code and I have tested my changes.
  3. I am willing to help maintain this change if there are issues with it later.
  4. It is compatible with the EUPL 1.2 license
  5. I have squashed any insignificant commits. (git rebase)
  6. I have checked that another pull request for this purpose does not exist.
  7. I have considered, and confirmed that this submission will be valuable to others.
  8. I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
  9. I give this submission freely, and claim no ownership to its content.

  • I have read the above and my PR is ready for review. Check this box to confirm

Signed-off-by: DL6ER <dl6er@dl6er.de>
@DL6ER DL6ER added the Bugfix label Jul 18, 2023
@DL6ER DL6ER requested a review from a team July 18, 2023 11:18

@PromoFaux PromoFaux left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested Working

@PromoFaux PromoFaux merged commit 395ceef into development-v6 Jul 18, 2023
@PromoFaux PromoFaux deleted the fix/dns_servers branch July 18, 2023 17:28
@PromoFaux PromoFaux mentioned this pull request Feb 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants