Skip to content

Fix Search Adlists layout#2649

Merged
DL6ER merged 3 commits into
development-v6from
fix/search_layout
Jul 24, 2023
Merged

Fix Search Adlists layout#2649
DL6ER merged 3 commits into
development-v6from
fix/search_layout

Conversation

@rdwebdesign

Copy link
Copy Markdown
Member

What does this PR aim to accomplish?

Current layout has 2 problems:

  • the whole output is using bold text (caused by some broken tags);
  • the input number field is not using the same style as other form controls.

How does this PR accomplish the above?

Removing the broken tags and adding some classes to the page elements.

Also fix a CSS selector to avoid braking inline form elements.

Link documentation PRs if any are needed to support this PR:

none


By submitting this pull request, I confirm the following:

  1. I have read and understood the contributors guide, as well as this entire template. I understand which branch to base my commits and Pull Requests against.
  2. I have commented my proposed changes within the code and I have tested my changes.
  3. I am willing to help maintain this change if there are issues with it later.
  4. It is compatible with the EUPL 1.2 license
  5. I have squashed any insignificant commits. (git rebase)
  6. I have checked that another pull request for this purpose does not exist.
  7. I have considered, and confirmed that this submission will be valuable to others.
  8. I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
  9. I give this submission freely, and claim no ownership to its content.

  • I have read the above and my PR is ready for review. Check this box to confirm

Signed-off-by: RD WebDesign <github@rdwebdesign.com.br>
Inline form controls should use `width: auto`.
Using `width: 100%` for `.form-inline .form-control` selector makes every inline form element 100% wide.
This is not intended.
Using a more specific selector force 100% only for controls inside datatables.

Signed-off-by: RD WebDesign <github@rdwebdesign.com.br>
Signed-off-by: RD WebDesign <github@rdwebdesign.com.br>

@DL6ER DL6ER left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screenshot from 2023-07-24 18-35-56

@DL6ER DL6ER merged commit 65ffba5 into development-v6 Jul 24, 2023
@DL6ER DL6ER deleted the fix/search_layout branch July 24, 2023 16:36
@PromoFaux PromoFaux mentioned this pull request Feb 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants