Skip to content

replaceAll() requires a global regex#2651

Merged
DL6ER merged 1 commit into
development-v6from
fix/replaceAll
Jul 24, 2023
Merged

replaceAll() requires a global regex#2651
DL6ER merged 1 commit into
development-v6from
fix/replaceAll

Conversation

@DL6ER

@DL6ER DL6ER commented Jul 24, 2023

Copy link
Copy Markdown
Member

What does this implement/fix?

Currently, development-v6 is broken. This is a regression from #2648.

This PR fixes #2650

Related issue or feature (if applicable): N/A

Pull request in docs with documentation (if applicable): N/A


By submitting this pull request, I confirm the following:

  1. I have read and understood the contributors guide, as well as this entire template. I understand which branch to base my commits and Pull Requests against.
  2. I have commented my proposed changes within the code.
  3. I am willing to help maintain this change if there are issues with it later.
  4. It is compatible with the EUPL 1.2 license
  5. I have squashed any insignificant commits. (git rebase)

Checklist:

  • The code change is tested and works locally.
  • I based my code and PRs against the repositories developmental branch.
  • I signed off all commits. Pi-hole enforces the DCO for all contributions
  • I signed all my commits. Pi-hole requires signatures to verify authorship
  • I have read the above and my PR is ready for review.

Signed-off-by: DL6ER <dl6er@dl6er.de>
@DL6ER DL6ER requested a review from a team July 24, 2023 16:32
@DL6ER DL6ER merged commit 624d481 into development-v6 Jul 24, 2023
@DL6ER DL6ER deleted the fix/replaceAll branch July 24, 2023 16:33
@PromoFaux PromoFaux mentioned this pull request Feb 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[development-v6]: Development-v6: empty last four blocks of admin page (top client, top domain, ....)

2 participants