Skip to content

Improve rendering of search results#2750

Merged
DL6ER merged 3 commits into
development-v6from
tweak/search_color
Oct 16, 2023
Merged

Improve rendering of search results#2750
DL6ER merged 3 commits into
development-v6from
tweak/search_color

Conversation

@DL6ER

@DL6ER DL6ER commented Oct 15, 2023

Copy link
Copy Markdown
Member

What does this implement/fix?

This PR seeks to improve rendering of the /api/search/{domain} results on the dashboard:

  1. Use color to indicate allow/block lists (anti-/gravity), allow/deny domains (exact/regex)
  2. Add info if a gravity list is actually of allow type (antigravity)
  3. Add info if there are more results than are requested

It depends on FTL from pi-hole/FTL#1665

Current development-v6 result:
Screenshot from 2023-10-15 11-44-13

This PR:
Screenshot from 2023-10-15 11-53-23

When there are too many results:
Screenshot from 2023-10-15 11-54-36

Related issue or feature (if applicable): N/A

Pull request in docs with documentation (if applicable): N/A


By submitting this pull request, I confirm the following:

  1. I have read and understood the contributors guide, as well as this entire template. I understand which branch to base my commits and Pull Requests against.
  2. I have commented my proposed changes within the code.
  3. I am willing to help maintain this change if there are issues with it later.
  4. It is compatible with the EUPL 1.2 license
  5. I have squashed any insignificant commits. (git rebase)

Checklist:

  • The code change is tested and works locally.
  • I based my code and PRs against the repositories developmental branch.
  • I signed off all commits. Pi-hole enforces the DCO for all contributions
  • I signed all my commits. Pi-hole requires signatures to verify authorship
  • I have read the above and my PR is ready for review.

DL6ER added 2 commits October 15, 2023 11:43
…(antigravity)

Signed-off-by: DL6ER <dl6er@dl6er.de>
…too small N

Signed-off-by: DL6ER <dl6er@dl6er.de>
@DL6ER

DL6ER commented Oct 15, 2023

Copy link
Copy Markdown
Member Author

I'd also be completely open to an entire redesign making this a really pretty page and not some mock thing that tries to mimic pihole -q on the CLI (but this time the web is actually doing things the CLI cannot yet do)

Signed-off-by: Christian König <ckoenig@posteo.de>
@DL6ER DL6ER merged commit 191f89d into development-v6 Oct 16, 2023
@DL6ER DL6ER deleted the tweak/search_color branch October 16, 2023 15:14
@PromoFaux PromoFaux mentioned this pull request Feb 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants