Fix mass-deletion of sessions on the settings -> API page#2765
Conversation
Signed-off-by: DL6ER <dl6er@dl6er.de>
|
Something not quite right here. Sometimes it deletes all but one session. Seems a bit random as to which session gets left over. |
|
Maybe it's an issue with |
|
I wasn't able to replicate the "all but one" issue using different browsers (Chrome, Firefox and Edge) on the same machine. You used different windows from the same browser (using incognito mode). I'm not sure if this could be related to the issue you are seeing. We probably need more tests. |
|
The issue was the concurrency of the deletions. This is fixed by the latest commit |
…ls finished. This also ensures our own session is NOT deleted on error so the user can still see the generated error message Signed-off-by: DL6ER <dl6er@dl6er.de>
5e3f2ca to
7595ceb
Compare
yubiuser
left a comment
There was a problem hiding this comment.
We have 3 functions now with very similar names: deleteSessions(), delSessions(ids) and delSession(id,...). The first one does not do much on it's own, maybe the single line var ids = [$(this).attr("data-del-id")]; can be part of delSessions()?
Signed-off-by: DL6ER <dl6er@dl6er.de>
What does this implement/fix?
See title and related Discourse topic.
Related issue or feature (if applicable): N/A
Pull request in docs with documentation (if applicable): N/A
By submitting this pull request, I confirm the following:
git rebase)Checklist:
developmentalbranch.