Conditional HTTPS hint on login page#2730
Merged
Merged
Conversation
…it is served an a port != 443, add this port as well Signed-off-by: DL6ER <dl6er@dl6er.de>
yubiuser
previously approved these changes
Oct 8, 2023
yubiuser
left a comment
Member
There was a problem hiding this comment.
Approving, but don't merge before the relevant FTL is merged. (Maybe changes here are required.)
I tried with ssl port 443, 8443 and non and it works as expected.
Signed-off-by: DL6ER <dl6er@dl6er.de>
rdwebdesign
previously requested changes
Oct 8, 2023
Co-authored-by: RD WebDesign <github@rdwebdesign.com.br> Signed-off-by: DL6ER <DL6ER@users.noreply.github.com>
yubiuser
approved these changes
Oct 9, 2023
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this implement/fix?
Show HTTPS hint on login page only when HTTPS is actually served. If it is served on a port != 443, add this port as well to the link
Depends on FTL in pi-hole/FTL#1653
Related issue or feature (if applicable): N/A
Pull request in docs with documentation (if applicable): N/A
By submitting this pull request, I confirm the following:
git rebase)Checklist:
developmentalbranch.