Skip to content

Fix Upstreams Query Log links#2843

Merged
DL6ER merged 1 commit into
development-v6from
fix/upstream_links
Nov 16, 2023
Merged

Fix Upstreams Query Log links#2843
DL6ER merged 1 commit into
development-v6from
fix/upstream_links

Conversation

@DL6ER

@DL6ER DL6ER commented Nov 16, 2023

Copy link
Copy Markdown
Member

What does this implement/fix?

Fix upstream links yielding no results on the Query Log if names are shown. It works by remembering which name belongs to which address and using this later on when a link is created:

Screenshot from 2023-11-16 12-51-59
Screenshot from 2023-11-16 12-51-49

This is a regression of #2827. This PR fixes #2833


Related issue or feature (if applicable): N/A

Pull request in docs with documentation (if applicable): N/A


By submitting this pull request, I confirm the following:

  1. I have read and understood the contributors guide, as well as this entire template. I understand which branch to base my commits and Pull Requests against.
  2. I have commented my proposed changes within the code.
  3. I am willing to help maintain this change if there are issues with it later.
  4. It is compatible with the EUPL 1.2 license
  5. I have squashed any insignificant commits. (git rebase)

Checklist:

  • The code change is tested and works locally.
  • I based my code and PRs against the repositories developmental branch.
  • I signed off all commits. Pi-hole enforces the DCO for all contributions
  • I signed all my commits. Pi-hole requires signatures to verify authorship
  • I have read the above and my PR is ready for review.

@DL6ER DL6ER merged commit 5c09620 into development-v6 Nov 16, 2023
@DL6ER DL6ER deleted the fix/upstream_links branch November 16, 2023 21:27
@PromoFaux PromoFaux mentioned this pull request Feb 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Clicking on an upstream server in the 'upstream servers' view on the Dashboard view shows an empty log list

2 participants