Skip to content

Update chartjs to 4.4.1#2892

Merged
yubiuser merged 1 commit into
development-v6from
chartjs_4.4.1
Dec 5, 2023
Merged

Update chartjs to 4.4.1#2892
yubiuser merged 1 commit into
development-v6from
chartjs_4.4.1

Conversation

@yubiuser

@yubiuser yubiuser commented Dec 4, 2023 •
edited
Loading

Copy link
Copy Markdown
Member

What does this PR aim to accomplish?:

Update chartjs to 4.4.1 release today.
https://github.com/chartjs/Chart.js/releases/tag/v4.4.1

There are no breaking changes, only bugfixes.

By submitting this pull request, I confirm the following:

  1. I have read and understood the contributors guide, as well as this entire template. I understand which branch to base my commits and Pull Requests against.
  2. I have commented my proposed changes within the code and I have tested my changes.
  3. I am willing to help maintain this change if there are issues with it later.
  4. It is compatible with the EUPL 1.2 license
  5. I have squashed any insignificant commits. (git rebase)
  6. I have checked that another pull request for this purpose does not exist.
  7. I have considered, and confirmed that this submission will be valuable to others.
  8. I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
  9. I give this submission freely, and claim no ownership to its content.
  • I have read the above and my PR is ready for review. Check this box to confirm

@yubiuser
Update chartjs to 4.4.1
a736b5b 
Signed-off-by: Christian König <ckoenig@posteo.de>
@yubiuser yubiuser requested a review from a team December 4, 2023 20:24
DL6ER
DL6ER reviewed Dec 4, 2023
View reviewed changes
Comment thread scripts/pi-hole/lua/header_authenticated.lp
<script src="<?=pihole.fileversion('scripts/vendor/datatables.min.js')?>"></script>
<script src="<?=pihole.fileversion('scripts/vendor/datatables.select.min.js')?>"></script>
<script src="<?=pihole.fileversion('scripts/vendor/datatables.buttons.min.js')?>"></script>
<script src="<?=pihole.fileversion('scripts/vendor/chart.umd.min.js')?>"></script>

@DL6ER DL6ER Dec 4, 2023

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are we dropping the min even if this is obviously a minified file? Is the answer: Because that's how they call the file upstream? (even if it seems strange they do this)

@yubiuser yubiuser Dec 5, 2023

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, this is the answer. As updating is a manual task, I thought it's easier to keep the filenames in sync for the next update round.

@yubiuser yubiuser merged commit 59f33ad into development-v6 Dec 5, 2023
@yubiuser yubiuser deleted the chartjs_4.4.1 branch December 5, 2023 19:40
@yubiuser yubiuser mentioned this pull request Dec 9, 2023
Merged
@PromoFaux PromoFaux mentioned this pull request Feb 18, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@DL6ER DL6ER DL6ER approved these changes

Assignees

No one assigned

Labels

Pi-hole v6.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@yubiuser @DL6ER