Fix error displaying when editing groups/clients/domains/lists#2808
Merged
Conversation
5 tasks
…ing shown. Also fix logic of the strings "enabling/disabling" as the variable "enabled" already has the new (not the current state). This was correct in groups.js, but not the others Signed-off-by: DL6ER <dl6er@dl6er.de>
778312e to
4d3c0cd
Compare
Member
Author
|
This bug has been reported on Discourse |
yubiuser
requested changes
Nov 9, 2023
Signed-off-by: DL6ER <dl6er@dl6er.de>
…ction only work on the first <td>-element and ensure we include both type and kind in the data-id attribute to make it really a unique selector Signed-off-by: DL6ER <dl6er@dl6er.de>
yubiuser
approved these changes
Nov 12, 2023
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this implement/fix?
Fix errors happening when editing groups/clients/domains/lists not being shown. Also fix logic of the strings "enabling/disabling" as the variable "enabled" already has the new (not the current state). This was correct in
groups.js, but not the othersThis bug concealed another bug in FTL that can be triggered by trying to edit a domain (e.g., disabling it) via the web interface:
Branch
development-v6:despite the error being logged in FTL.log:
This PR
The issue itself is fixed by pi-hole/FTL#1735
Related issue or feature (if applicable): N/A
Pull request in docs with documentation (if applicable): N/A
By submitting this pull request, I confirm the following:
git rebase)Checklist:
developmentalbranch.