Show Reset Zoom button when zoomed in#2813
Merged
Merged
Conversation
Signed-off-by: DL6ER <dl6er@dl6er.de>
- use class to style buttons and info icons (move style to pi-hole.css) - add negative margin to avoid small jump when the button is shown - use the new classes to simplify jquery selectors
yubiuser
approved these changes
Nov 8, 2023
yubiuser
left a comment
Member
There was a problem hiding this comment.
Works nicely. If @rdwebdesign does not have any additional good idea how to handle $(chart.canvas).parent().parent().parent().find this is good to go.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this implement/fix?
Show Reset Zoom buttons when zooming in
The clients chart was already zoomed in when starting the recording.
Javascript-wise, this may not be the most elegant way, but without the chain of
neither
.find()nor.closest()were able to find the elements I was looking for.Related issue or feature (if applicable): N/A
Pull request in docs with documentation (if applicable): N/A
By submitting this pull request, I confirm the following:
git rebase)Checklist:
developmentalbranch.