Skip to content

Shorten animation delay#2815

Merged
yubiuser merged 1 commit into
development-v6from
tweak/delay
Nov 13, 2023
Merged

Shorten animation delay#2815
yubiuser merged 1 commit into
development-v6from
tweak/delay

Conversation

@yubiuser

@yubiuser yubiuser commented Nov 8, 2023

Copy link
Copy Markdown
Member

What does this PR aim to accomplish?:

Startup animation of the charts is delayed until the reach the viewport. This PR reduces the fraction of the chart that needs to be within the viewport before the animation triggers. Also the delay is reduced.
This should prevent seeing 50% empty charts before the animation starts, but keeping the viewport delay.


By submitting this pull request, I confirm the following:

  1. I have read and understood the contributors guide, as well as this entire template. I understand which branch to base my commits and Pull Requests against.
  2. I have commented my proposed changes within the code and I have tested my changes.
  3. I am willing to help maintain this change if there are issues with it later.
  4. It is compatible with the EUPL 1.2 license
  5. I have squashed any insignificant commits. (git rebase)
  6. I have checked that another pull request for this purpose does not exist.
  7. I have considered, and confirmed that this submission will be valuable to others.
  8. I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
  9. I give this submission freely, and claim no ownership to its content.

  • I have read the above and my PR is ready for review. Check this box to confirm

Signed-off-by: Christian König <ckoenig@posteo.de>
@yubiuser yubiuser requested review from a team and DL6ER November 8, 2023 21:09

@DL6ER DL6ER left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screenshot from 2023-11-13 23-23-17

and then

Screenshot from 2023-11-13 23-23-20

@yubiuser yubiuser merged commit e0ca2b2 into development-v6 Nov 13, 2023
@yubiuser yubiuser deleted the tweak/delay branch November 13, 2023 22:25
@PromoFaux PromoFaux mentioned this pull request Feb 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants