Prevent multi-login due to slow password hashing#2826
Merged
Conversation
Signed-off-by: DL6ER <dl6er@dl6er.de>
0c5c9e0 to
c5b51e8
Compare
DL6ER
commented
Nov 13, 2023
| * This file is copyright under the latest version of the EUPL. | ||
| * Please see LICENSE file for your rights under this license. */ | ||
|
|
||
| /* global utils:false */ |
Member
Author
There was a problem hiding this comment.
utils.js is included from header.lp
yubiuser
approved these changes
Nov 13, 2023
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this implement/fix?
There is currently no limit on how often you can submit the password until you are finally logged in. This is most noticeable on very low-end hardware, such as an emulated

armv7target in the following example:After this PR, multiple logins during password validation are prevented:

Related issue or feature (if applicable): N/A
Pull request in docs with documentation (if applicable): N/A
By submitting this pull request, I confirm the following:
git rebase)Checklist:
developmentalbranch.