Do not accept comma to separate regex#2835
Merged
Merged
Conversation
…ultiple at once. It is not possible to use comma as this has a special meaning in the regex world Signed-off-by: DL6ER <dl6er@dl6er.de>
8dfbbf4 to
0371f87
Compare
Member
|
Should we also remove the ability to split adlists, groups,clients by comma just to make it more consistent (and to match the hint which only says "space-seperated")? |
Member
Author
|
I was thinking about this but thought that it may actually be good to be somewhat more generous concerning separators where they don't cause trouble. My feeling is that users will simply try this without actually reading anything |
rdwebdesign
previously approved these changes
Nov 15, 2023
Signed-off-by: DL6ER <dl6er@dl6er.de>
Signed-off-by: Christian König <ckoenig@posteo.de>
yubiuser
approved these changes
Nov 16, 2023
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this implement/fix?
Domains/Regex must be either space or newline separated when adding multiple at once. It is not possible to use comma as this has a special meaning in the regex world
Can be tested by adding
Before:

Now:

It is advisable to use FTL from PR pi-hole/FTL#1759 to prevent FTL from crashing during the review test.
Fixes #2834
Related issue or feature (if applicable): N/A
Pull request in docs with documentation (if applicable): N/A
By submitting this pull request, I confirm the following:
git rebase)Checklist:
developmentalbranch.