Skip to content

Ran autoprefixer#3246

Merged
DL6ER merged 1 commit into
pi-hole:developmentfrom
XhmikosR:xmr/css
Mar 9, 2025
Merged

Ran autoprefixer#3246
DL6ER merged 1 commit into
pi-hole:developmentfrom
XhmikosR:xmr/css

Conversation

@XhmikosR

@XhmikosR XhmikosR commented Feb 22, 2025

Copy link
Copy Markdown
Contributor

Thank you for your contribution to the Pi-hole Community!

Please read the comments below to help us consider your Pull Request.

We are all volunteers and completing the process outlined will help us review your commits quicker.

Please make sure you

  1. Base your code and PRs against the repositories developmental branch.
  2. Sign Off all commits as we enforce the DCO for all contributions
  3. Sign all your commits as they must have verified signatures
  4. File a pull request for any change that requires changes to our documentation at our documentation repo

What does this PR aim to accomplish?:

Clean up redundant prefixes based on the currently set browserslist.

How does this PR accomplish the above?:

Link documentation PRs if any are needed to support this PR:


By submitting this pull request, I confirm the following:

  1. I have read and understood the contributors guide, as well as this entire template. I understand which branch to base my commits and Pull Requests against.
  2. I have commented my proposed changes within the code and I have tested my changes.
  3. I am willing to help maintain this change if there are issues with it later.
  4. It is compatible with the EUPL 1.2 license
  5. I have squashed any insignificant commits. (git rebase)
  6. I have checked that another pull request for this purpose does not exist.
  7. I have considered, and confirmed that this submission will be valuable to others.
  8. I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
  9. I give this submission freely, and claim no ownership to its content.

  • I have read the above and my PR is ready for review. Check this box to confirm

@yubiuser yubiuser left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wouldn't it make sense to run autoprefixer as you did automatically on every PR.
We even have code for this in packages.json

@XhmikosR

XhmikosR commented Feb 22, 2025 via email

Copy link
Copy Markdown
Contributor Author

Move selector where appropriate

Signed-off-by: XhmikosR <xhmikosr@gmail.com>
@yubiuser yubiuser requested a review from rdwebdesign February 22, 2025 20:37
@rdwebdesign

Copy link
Copy Markdown
Member

@XhmikosR

Clean up redundant prefixes based on the currently set browserslist.

Can you please explicitly right the current browserslist, so we can check them when we read this PR in the future?

@XhmikosR

XhmikosR commented Mar 8, 2025

Copy link
Copy Markdown
Contributor Author

No reason to do that, one can do it at any time with npx browserslist and that changes based on browser's usage percentage.

@DL6ER DL6ER left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything seems fine in here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants