Ran autoprefixer#3246
Merged
Merged
Conversation
yubiuser
reviewed
Feb 22, 2025
yubiuser
left a comment
Member
There was a problem hiding this comment.
Wouldn't it make sense to run autoprefixer as you did automatically on every PR.
We even have code for this in packages.json
Contributor
Author
|
That's for you guys to decide. I added the script there years ago.
Generally it's safe but prettier might complain after running auto prefixer
…On Sat, Feb 22, 2025, 16:19 yubiuser ***@***.***> wrote:
***@***.**** commented on this pull request.
Wouldn't it make sense to run autoprefixer as you did automatically on
every PR.
We even have code for this in packages.json
—
Reply to this email directly, view it on GitHub
<#3246 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AACVLNNH5SADWZDMJU4KZBL2RCBQ5AVCNFSM6AAAAABXVAMLR2VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDMMZUHAYTKMZTHE>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Move selector where appropriate Signed-off-by: XhmikosR <xhmikosr@gmail.com>
Member
Can you please explicitly right the current browserslist, so we can check them when we read this PR in the future? |
Contributor
Author
|
No reason to do that, one can do it at any time with |
Merged
This was referenced Jul 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thank you for your contribution to the Pi-hole Community!
Please read the comments below to help us consider your Pull Request.
We are all volunteers and completing the process outlined will help us review your commits quicker.
Please make sure you
What does this PR aim to accomplish?:
Clean up redundant prefixes based on the currently set browserslist.
How does this PR accomplish the above?:
Link documentation PRs if any are needed to support this PR:
By submitting this pull request, I confirm the following:
git rebase)