Skip to content

.gitattributes: enforce LF#3282

Merged
yubiuser merged 1 commit into
pi-hole:developmentfrom
XhmikosR:patch-1
Mar 8, 2025
Merged

.gitattributes: enforce LF#3282
yubiuser merged 1 commit into
pi-hole:developmentfrom
XhmikosR:patch-1

Conversation

@XhmikosR

@XhmikosR XhmikosR commented Mar 6, 2025

Copy link
Copy Markdown
Contributor

Thank you for your contribution to the Pi-hole Community!

Please read the comments below to help us consider your Pull Request.

We are all volunteers and completing the process outlined will help us review your commits quicker.

Please make sure you

  1. Base your code and PRs against the repositories developmental branch.
  2. Sign Off all commits as we enforce the DCO for all contributions
  3. Sign all your commits as they must have verified signatures
  4. File a pull request for any change that requires changes to our documentation at our documentation repo

What does this PR aim to accomplish?:

How does this PR accomplish the above?:

Link documentation PRs if any are needed to support this PR:


By submitting this pull request, I confirm the following:

  1. I have read and understood the contributors guide, as well as this entire template. I understand which branch to base my commits and Pull Requests against.
  2. I have commented my proposed changes within the code and I have tested my changes.
  3. I am willing to help maintain this change if there are issues with it later.
  4. It is compatible with the EUPL 1.2 license
  5. I have squashed any insignificant commits. (git rebase)
  6. I have checked that another pull request for this purpose does not exist.
  7. I have considered, and confirmed that this submission will be valuable to others.
  8. I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
  9. I give this submission freely, and claim no ownership to its content.

  • I have read the above and my PR is ready for review. Check this box to confirm

Signed-off-by: XhmikosR <xhmikosr@gmail.com>
@yubiuser

yubiuser commented Mar 6, 2025

Copy link
Copy Markdown
Member

From my understanding, withtext=auto, git will already convert line endings to LF on checkout/in

https://git-scm.com/docs/gitattributes#_checking_out_and_checking_in

@XhmikosR

XhmikosR commented Mar 6, 2025

Copy link
Copy Markdown
Contributor Author

Yeah, but you'll have CRLF on Windows because autocrlf is set to true by default. This way, everything will be LF everywhere.

@rdwebdesign

Copy link
Copy Markdown
Member

This way, everything will be LF everywhere.

Why is LF needed in Windows?

@XhmikosR

XhmikosR commented Mar 7, 2025

Copy link
Copy Markdown
Contributor Author

It's not needed, like CRLF is not needed nowadays. So, there's no point in keeping CRLF or CR nowadays. LF works everywhere.

FYI that's what we have in docs for years, did anyone notice any issue? :)

@yubiuser yubiuser merged commit a9bfbf8 into pi-hole:development Mar 8, 2025
@XhmikosR

XhmikosR commented Mar 8, 2025

Copy link
Copy Markdown
Contributor Author

This should be backported to the other repos where applicable too later.

@PromoFaux PromoFaux mentioned this pull request Mar 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants