Sort interfaces#3284
Conversation
- interfaces that do not depend on others (and have no children) are placed at the top of the treeview - interfaces that do have children get them directly assigned below them Signed-off-by: DL6ER <dl6er@dl6er.de>
yubiuser
left a comment
There was a problem hiding this comment.
I don't have a way to test this, as I don't have any virtual interfaces. But looking at your screenshot I noticed three veth interfaces blow br-99. I guess this is the master and the 3 child interfaces. To make it clearer that they belong together, could the children get a small indention?
Same issue here... I will try this later in a different machine. |
|
Maybe we can try using indentation and a single icon, instead of using 2 icons, similar to this image: I will try something. |
|
Or maybe something like this: |
acfc2f6 to
85dd3de
Compare
|
I'd approve it if I could ;-) |
yubiuser
left a comment
There was a problem hiding this comment.
We should squash down to 1-2 commits. Otherwise can go.
Before
After
- Add and format the arrow - Remove the icon used to indent child interfaces (the arrow is enough) Signed-off-by: RD WebDesign <github@rdwebdesign.com.br>
I will squash my commits and FP. |
d081571 to
90f71a4
Compare
|
GHA seems to be having a hard time, set this to auto merge once it's done the CI stuff |
What does this implement/fix?
Sort interfaces
Related issue or feature (if applicable): N/A
Pull request in docs with documentation (if applicable): N/A
By submitting this pull request, I confirm the following:
git rebase)Checklist:
developmentalbranch.