Skip to content

Improve HTTPS detection behind reverse proxy#3285

Merged
DL6ER merged 1 commit into
developmentfrom
fix/teleporter_https
Mar 6, 2025
Merged

Improve HTTPS detection behind reverse proxy#3285
DL6ER merged 1 commit into
developmentfrom
fix/teleporter_https

Conversation

@DL6ER

@DL6ER DL6ER commented Mar 6, 2025

Copy link
Copy Markdown
Member

What does this implement/fix?

Move the decision whether we are showing the no-HTTPS warning from server-side (where no https may be used when a reverse proxy is used) to user-side where this is more definite

Related issue or feature (if applicable): N/A

Pull request in docs with documentation (if applicable): N/A


By submitting this pull request, I confirm the following:

  1. I have read and understood the contributors guide, as well as this entire template. I understand which branch to base my commits and Pull Requests against.
  2. I have commented my proposed changes within the code.
  3. I am willing to help maintain this change if there are issues with it later.
  4. It is compatible with the EUPL 1.2 license
  5. I have squashed any insignificant commits. (git rebase)

Checklist:

  • The code change is tested and works locally.
  • I based my code and PRs against the repositories developmental branch.
  • I signed off all commits. Pi-hole enforces the DCO for all contributions
  • I signed all my commits. Pi-hole requires signatures to verify authorship
  • I have read the above and my PR is ready for review.

…rver-side (where no https may be used when a reverse proxy is used) to user-side where this is more definite

Signed-off-by: DL6ER <dl6er@dl6er.de>
@DL6ER DL6ER requested a review from a team March 6, 2025 19:01
@DL6ER DL6ER merged commit 5519b9d into development Mar 6, 2025
@DL6ER DL6ER deleted the fix/teleporter_https branch March 6, 2025 19:11
@PromoFaux PromoFaux mentioned this pull request Mar 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants