Use modernized waitMe plugin#3213
Conversation
|
There is no |
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
1 similar comment
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
|
Nice to see the jQuery usage to drop even if it's a little :) That being said, I'd move this package to the vendor folder for now and move on if it works OK like the previous plugin. |
|
Conflicts have been resolved. |
|
@yubiuser I suggest that you move forward with this and remove the package.json changes for now. Assuming that this works the same as the previous plugin. I have already started the work on reducing the jQuery usage in our code, so the less jQuery, the better. Just wait after #3295 is merged and move the new assets where they belong better (vendor first grouped together like I did in #3295). |
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
|
Conflicts have been resolved. |
Signed-off-by: yubiuser <github@yubiuser.dev>
|
The author has published an |
What does this PR aim to accomplish?:
Updates the used
waitMepackage because it's outdated and depends on an outdatedjqueryversionHow does this PR accomplish the above?:
Replace the package with a modernized version found at https://github.com/carlosvidal/modernized-waitme which does not rely on
jqueryBy submitting this pull request, I confirm the following:
git rebase)