Skip to content

header: fix runtime error when query_string is null#3395

Merged
yubiuser merged 1 commit into
pi-hole:developmentfrom
XhmikosR:patch-1
Apr 21, 2025
Merged

header: fix runtime error when query_string is null#3395
yubiuser merged 1 commit into
pi-hole:developmentfrom
XhmikosR:patch-1

Conversation

@XhmikosR

@XhmikosR XhmikosR commented Apr 14, 2025

Copy link
Copy Markdown
Contributor

Before:

2025-04-14 08:32:18.364 LSP Kepler: call failed: runtime error: [string "/var/www/html/admin/scripts/lua/header.lp"]:29: attempt to index a nil value (field 'query_string')
2025-04-14 08:32:18.365 LSP Kepler: call failed: runtime error: aborting
2025-04-14 08:32:18.365 LSP Kepler: call failed: runtime error: aborting

More fixes are in my https://github.com/XhmikosR/web/commits/xmr/reduce-jquery/ branch, but I will be able to upstream them after we are done with #3388.


Thank you for your contribution to the Pi-hole Community!

Please read the comments below to help us consider your Pull Request.

We are all volunteers and completing the process outlined will help us review your commits quicker.

Please make sure you

  1. Base your code and PRs against the repositories developmental branch.
  2. Sign Off all commits as we enforce the DCO for all contributions
  3. Sign all your commits as they must have verified signatures
  4. File a pull request for any change that requires changes to our documentation at our documentation repo

What does this PR aim to accomplish?:

How does this PR accomplish the above?:

Link documentation PRs if any are needed to support this PR:


By submitting this pull request, I confirm the following:

  1. I have read and understood the contributors guide, as well as this entire template. I understand which branch to base my commits and Pull Requests against.
  2. I have commented my proposed changes within the code and I have tested my changes.
  3. I am willing to help maintain this change if there are issues with it later.
  4. It is compatible with the EUPL 1.2 license
  5. I have squashed any insignificant commits. (git rebase)
  6. I have checked that another pull request for this purpose does not exist.
  7. I have considered, and confirmed that this submission will be valuable to others.
  8. I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
  9. I give this submission freely, and claim no ownership to its content.

  • I have read the above and my PR is ready for review. Check this box to confirm

Signed-off-by: XhmikosR <xhmikosr@gmail.com>
@yubiuser

Copy link
Copy Markdown
Member

How did you reproduce the error in the first place?

@XhmikosR

Copy link
Copy Markdown
Contributor Author

Just go to any tailog page and remove the query param and hit enter. Then check the ftl log.

@XhmikosR

Copy link
Copy Markdown
Contributor Author

Note that the redirect doesn't current work properly, I've fixed that too in my branch but I'll upstream it later because there will be conflicts.

@yubiuser yubiuser merged commit 1d9a079 into pi-hole:development Apr 21, 2025
@PromoFaux PromoFaux mentioned this pull request May 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants