Skip to content

footer: drop redundant addAdvancedInfo() call#3467

Merged
yubiuser merged 1 commit into
pi-hole:developmentfrom
XhmikosR:patch-2
May 18, 2025
Merged

footer: drop redundant addAdvancedInfo() call#3467
yubiuser merged 1 commit into
pi-hole:developmentfrom
XhmikosR:patch-2

Conversation

@XhmikosR

@XhmikosR XhmikosR commented May 18, 2025

Copy link
Copy Markdown
Contributor

@DL6ER was this supposed to be hidden unless expert settings is true?

If so, I will have to backport this patch after adapting it for development XhmikosR@084c72e

Otherwise, the addAdvancedInfo() call seems redundant.


Thank you for your contribution to the Pi-hole Community!

Please read the comments below to help us consider your Pull Request.

We are all volunteers and completing the process outlined will help us review your commits quicker.

Please make sure you

  1. Base your code and PRs against the repositories developmental branch.
  2. Sign Off all commits as we enforce the DCO for all contributions
  3. Sign all your commits as they must have verified signatures
  4. File a pull request for any change that requires changes to our documentation at our documentation repo

What does this PR aim to accomplish?:

How does this PR accomplish the above?:

Link documentation PRs if any are needed to support this PR:


By submitting this pull request, I confirm the following:

  1. I have read and understood the contributors guide, as well as this entire template. I understand which branch to base my commits and Pull Requests against.
  2. I have commented my proposed changes within the code and I have tested my changes.
  3. I am willing to help maintain this change if there are issues with it later.
  4. It is compatible with the EUPL 1.2 license
  5. I have squashed any insignificant commits. (git rebase)
  6. I have checked that another pull request for this purpose does not exist.
  7. I have considered, and confirmed that this submission will be valuable to others.
  8. I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
  9. I give this submission freely, and claim no ownership to its content.

  • I have read the above and my PR is ready for review. Check this box to confirm

Signed-off-by: XhmikosR <xhmikosr@gmail.com>
@rdwebdesign

Copy link
Copy Markdown
Member

was this supposed to be hidden unless expert settings is true?

Originally this was hidden (commit 9f383893), but a lot of things were changed in settings pages after that.

At that time there were 3 levels (Basic, Advanced and Expert) and many things were hidden in basic level. Some items were visible only on the Expert level.
Now, the levels were simplified to 2 levels: Basic and Expert.

Personally I think there's no need to hide this information in any level.

@yubiuser yubiuser left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with rd, there is no need to hide this info. And currently, we already show it always

@yubiuser yubiuser merged commit 53a8835 into pi-hole:development May 18, 2025
8 checks passed
@PromoFaux PromoFaux mentioned this pull request May 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants