footer: drop redundant addAdvancedInfo() call#3467
Merged
Conversation
Signed-off-by: XhmikosR <xhmikosr@gmail.com>
Member
Originally this was hidden (commit 9f383893), but a lot of things were changed in settings pages after that. At that time there were 3 levels (Basic, Advanced and Expert) and many things were hidden in basic level. Some items were visible only on the Expert level. Personally I think there's no need to hide this information in any level. |
yubiuser
approved these changes
May 18, 2025
yubiuser
left a comment
Member
There was a problem hiding this comment.
I agree with rd, there is no need to hide this info. And currently, we already show it always
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@DL6ER was this supposed to be hidden unless expert settings is true?
If so, I will have to backport this patch after adapting it for development XhmikosR@084c72e
Otherwise, the addAdvancedInfo() call seems redundant.
Thank you for your contribution to the Pi-hole Community!
Please read the comments below to help us consider your Pull Request.
We are all volunteers and completing the process outlined will help us review your commits quicker.
Please make sure you
What does this PR aim to accomplish?:
How does this PR accomplish the above?:
Link documentation PRs if any are needed to support this PR:
By submitting this pull request, I confirm the following:
git rebase)