Skip to content

Use the same interface name used by FTL in DNS Settings page#3481

Merged
rdwebdesign merged 1 commit into
developmentfrom
tweak/interface_name
May 22, 2025
Merged

Use the same interface name used by FTL in DNS Settings page#3481
rdwebdesign merged 1 commit into
developmentfrom
tweak/interface_name

Conversation

@rdwebdesign

@rdwebdesign rdwebdesign commented May 21, 2025

Copy link
Copy Markdown
Member

What does this PR aim to accomplish?

If dns.interface is empty in pihole.toml we use the first interface returned by network/gateway endpoint, just like FTL.

Complement of #3436 and pi-hole/FTL#2456

How does this PR accomplish the above?

Use the value of gateway[0].interface.


By submitting this pull request, I confirm the following:

  1. I have read and understood the contributors guide, as well as this entire template. I understand which branch to base my commits and Pull Requests against.
  2. I have commented my proposed changes within the code and I have tested my changes.
  3. I am willing to help maintain this change if there are issues with it later.
  4. It is compatible with the EUPL 1.2 license
  5. I have squashed any insignificant commits. (git rebase)
  6. I have checked that another pull request for this purpose does not exist.
  7. I have considered, and confirmed that this submission will be valuable to others.
  8. I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
  9. I give this submission freely, and claim no ownership to its content.

  • I have read the above and my PR is ready for review. Check this box to confirm

@rdwebdesign rdwebdesign requested a review from a team as a code owner May 21, 2025 23:30
@rdwebdesign rdwebdesign force-pushed the tweak/interface_name branch from 864d1c4 to ef5ba2c Compare May 22, 2025 00:22
If `dns.interface` is empty in pihole.toml we use the first interface, just like FTL.

Signed-off-by: RD WebDesign <github@rdwebdesign.com.br>
@rdwebdesign rdwebdesign force-pushed the tweak/interface_name branch from ef5ba2c to cb575a5 Compare May 22, 2025 00:27
@rdwebdesign rdwebdesign merged commit a1814d6 into development May 22, 2025
11 checks passed
@rdwebdesign rdwebdesign deleted the tweak/interface_name branch May 22, 2025 17:35
@PromoFaux PromoFaux mentioned this pull request May 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants