high-contrast.css: fix duplicate selector#3411
Merged
Merged
Conversation
rdwebdesign
requested changes
Apr 24, 2025
Comment on lines
370
to
373
| .small-box > .small-box-footer { | ||
| color: #fff; | ||
| } | ||
| .small-box > .small-box-footer { | ||
| .small-box > .small-box-footer:hover { | ||
| background: rgba(0, 0, 0, 0.3); | ||
| } |
Member
There was a problem hiding this comment.
No. The darker background should be used without hover.
I don't remember what I did, but it should be just one selector containing both rules:
.small-box > .small-box-footer {
color: #fff;
background: rgba(0, 0, 0, 0.3);
}I couldn't add a code suggestion because there were deleted lines and the interface doesn't allow.
Signed-off-by: XhmikosR <xhmikosr@gmail.com>
rdwebdesign
approved these changes
Apr 24, 2025
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Should fix one CodeFactor issue.
/CC @rdwebdesign who made the theme. Unsure if this was supposed to be
:hoveror combined with the previous selector.Thank you for your contribution to the Pi-hole Community!
Please read the comments below to help us consider your Pull Request.
We are all volunteers and completing the process outlined will help us review your commits quicker.
Please make sure you
What does this PR aim to accomplish?:
How does this PR accomplish the above?:
Link documentation PRs if any are needed to support this PR:
By submitting this pull request, I confirm the following:
git rebase)