Bind address to new element instead of raw HTML construction#3567
Conversation
Signed-off-by: DL6ER <dl6er@dl6er.de>
yubiuser
left a comment
There was a problem hiding this comment.
Is this expected?
Your fix works. However, I like the idea from #3552 where we had a function that checks if a string is encoded or not and performs encoding if necessary. I still think, this could be useful in other places as well.
|
Yes, this is expected and it has been like that before. The idea is to use a (reversible) encoded form of the element itself as identifier so we don't need to keep a list id <-> url up-to-date while the table is being modified.
But we agreed on the add-another-icons-framework that we should not add new things without applications for them :-) Here, we exactly know that there is no escaping to be done, hence, we don't do it. |
yubiuser
left a comment
There was a problem hiding this comment.
add-another-icons-framework that we should not add new things without applications for them
Ok, convinced. It might have been me who set this requirement....
What does this implement/fix?
Fix incorrectly doubly-escaped links. This is a follow-up on the abandoned #3552
Can be tested by adding the list
and seeing that the click-link does not work on current
development.Related issue or feature (if applicable): N/A
Pull request in docs with documentation (if applicable): N/A
By submitting this pull request, I confirm the following:
git rebase)Checklist:
developmentbranch.