Cancel gathering before removing candidates#842
Conversation
| } | ||
|
|
||
| agent.loop = taskloop.New(func() { | ||
| agent.gatherCandidateCancel() |
There was a problem hiding this comment.
This is the main change. Other bits are passing around ICE agent logger into TCP mux. The ICE agent logger could have more context and could be useful.
Guess, I should add it to UDP mux also?
There was a problem hiding this comment.
Oh well, this breaks API checks. Will probably remove it then.
There was a problem hiding this comment.
okay, cleaned them up. This is the only change now.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #842 +/- ##
==========================================
+ Coverage 87.12% 87.27% +0.14%
==========================================
Files 43 43
Lines 4825 4825
==========================================
+ Hits 4204 4211 +7
+ Misses 446 440 -6
+ Partials 175 174 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
1251e01 to
9ae9623
Compare
cnderrauber
left a comment
There was a problem hiding this comment.
Good job for fixing this!!
When ICE agent is closed, the connections from UDP/TCP mux were removed before gathering was canceled. This led to candidate gathering adding entries to UDP mux which were not cleaned up.
9ae9623 to
8ba0d1a
Compare
Description
When ICE agent is closed, the connections from UDP/TCP mux were removed before gathering was canceled. This led to candidate gathering adding entries to UDP mux which were not cleaned up.
Also passing into logger to the mux as ICE agent logger could have more context and is useful to see the context.