Integrate record cache into event loop#270
Open
backkem wants to merge 2 commits into
Open
Conversation
Wire the cache from #266 into the mDNS event loop: - Insert all answer/additional records on receive - Periodic sweep of expired entries (10s interval) - Proactive cache refresh at 80/85/90/95% TTL (RFC 6762 §5.2) - WithCacheRefresh(bool) / WithRefreshInterval(dur) options - Refresh enabled by default in NewServer, disabled in legacy Server()
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #270 +/- ##
==========================================
+ Coverage 80.61% 82.03% +1.42%
==========================================
Files 7 8 +1
Lines 1599 1893 +294
==========================================
+ Hits 1289 1553 +264
- Misses 201 228 +27
- Partials 109 112 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
WithCacheRefresh(bool)andWithRefreshInterval(time.Duration)server optionsNewServer, disabled in legacyServer()to preserve existing behaviorBuilds on #266 (record cache with TTL management). This PR supersedes #266 — the commits from #266 are included here. Both can be merged separately (cache first, then integration) or together via this PR.