Skip to content

Fix null pathReference causing error in convertToWebPath #18800

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
michaelhader wants to merge 2 commits into
base: 11.5
Choose a base branch
from
Open

Fix null pathReference causing error in convertToWebPath #18800

michaelhader wants to merge 2 commits into from
+21 −4

Conversation

@michaelhader
Copy link
Contributor

@michaelhader michaelhader commented Nov 3, 2025

Changes in this pull request

Fixes a bug where $this->pathReference could remain null in Pimcore\Model\Asset\Thumbnail\ImageThumbnailTrait and \Pimcore\Model\Asset\Video\ImageThumbnail, causing an error when convertToWebPath() attempts to process a null $path at line 308 in ImageThumbnailTrait.php :

$path = urlencode_ignore_slash($path);

Additional info

  • Initialize $this->pathReference with error fallback at lines 145 and 156
  • Uses existing "filetype-not-supported" icon as fallback

@github-actions
Copy link

github-actions bot commented Nov 3, 2025

Review Checklist

  • Target branch (11.5 for bug fixes, others 11.x)
  • Tests (if it's testable code, there should be a test for it - get help)
  • Docs (every functionality needs to be documented, see here)
  • Migration incl. install.sql (e.g. if the database schema changes, ...)
  • Upgrade notes (deprecations, important information, migration hints, ...)
  • Label
  • Milestone

@github-actions
Copy link

github-actions bot commented Nov 3, 2025 •
edited
Loading

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@michaelhader
Copy link
Contributor Author

michaelhader commented Nov 3, 2025

I have read the CLA Document and I hereby sign the CLA

@sonarqubecloud
Copy link

sonarqubecloud bot commented Nov 4, 2025

Quality Gate Failed Quality Gate failed

Failed conditions
1 New Critical Issues (required ≤ 0)
1 New Major Issues (required ≤ 0)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

@michaelhader
Copy link
Contributor Author

michaelhader commented Nov 17, 2025

Codeception test failure is unrelated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@michaelhader