@huy-hn-nguyen, couple of comments around the PR in general -

• Could you add relevant test cases for the new encryption feature? I see these are currently missing from the PR.
• How are we thinking around documenting these changes? For example - I see in Platform Automation Docs here, there are aws configs. Should we be adding encrypted & kms_key_id in this documentation.

Also

• In GitHub Release Notes when releasing
• How about this existing KB Article: https://knowledge.broadcom.com/external/article/293776. Its good to check if we need to indicate as its now have got fixed with a newer release.

How are we thinking around documenting these changes? For example - I see in Platform Automation Docs here, there are aws configs. Should we be adding encrypted & kms_key_id in this documentation.

Good catch regarding documentation, i don't think we are documenting the sub-commands in om cli repo, but i agree that we should update the PA docs with an volume encryption config example

@sanjimoh I added the test cases for this PR. I also updated this file (https://github.com/pivotal/docs-platform-automation/blob/TNZ-50715/docs/examples/opsman-config/aws.yml) from docs-platform-automation. I will create the PR for this change as send out for review. I checked with Kathy about the KB as well. I am waiting for the response.

@huy-hn-nguyen will you be adding the tests that we discussed yesterday in a subsequent pr? Can you also enable running the aws tests in CI?

@huy-hn-nguyen will you be adding the tests that we discussed yesterday in a subsequent pr? Can you also enable running the aws tests in CI?

@yharish991-brcm Regarding to the test cases we discussed, I tried to get the information of the created VM. The returned result was "running", no other information provided (maybe because it was a simulated VM, not a real one from AWS). If not an urgent, I think we should postpone this test scenario until we update the returned result. I noticed that the test set, https://github.com/pivotal-cf/om/actions/runs/21601401642/job/62248040234, not only disabled AWS creating VM, but also disabled test cases for Azure, VSphere, and GCP as well. So, I am not enabled AWS tests until I find out the reason for this.

@sanjimoh I added the test cases for this PR. I also updated this file (https://github.com/pivotal/docs-platform-automation/blob/TNZ-50715/docs/examples/opsman-config/aws.yml) from docs-platform-automation. I will create the PR for this change as send out for review. I checked with Kathy about the KB as well. I am waiting for the response.

@huy-hn-nguyen: encrypted is optional & defaults to false. However, pl. consider adding a test case for when encrypted is completely omitted from config not just false. This validates backward compatibility - existing configs without the encrypted field should continue to work. Otherwise changes looks good to me.

@sanjimoh I added the checking for Encrypted and KmsKeyId so that the tests will be executed even when encrypted and kms_key_id are omitted from config file. No new test case needed since the tests from line #79 of aws_test.go already covered this scenario.