Skip to content

[v11] webgpu/Wireframe accepts a simplify prop it never reads #2815

Description

@DennisSmolek

webgpu/Wireframe's simplify prop does nothing

simplify is accepted in the props type and documented, but the only place the identifier appears in the implementation is inside a useLayoutEffect dependency array — it is never read.

Cosmetic next to #2813 and the barycentric sizing bug, but it is a documented prop that silently no-ops, which is the kind of thing that costs someone an afternoon.

Either wire it up to match the legacy behaviour or remove it from the public type and the docs.

Found while writing stories for #2801.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    v11For v11 related taskswebgpuWebGPU Related issue

    Type

    No type

    Projects

    No projects

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions