feat(Select): customisable box-select activator#2730
Open
SAY-5 wants to merge 1 commit into
Open
Conversation
|
@SAY-5 is attempting to deploy a commit to the Poimandres Team on Vercel. A member of the Team first needs to authorize it. |
Member
|
The API does bug me lol but I cant remember exactly why. do you have a link to that convo? |
Author
|
It is your own comment on the linked issue: #2308 (comment) ("I agree the api bugs me"). Happy to adjust the prop shape if you have a preferred design. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Resolves #2308. @DennisSmolek mentioned the API bugs him and that PRs are welcome targeting v11.
What
Add an optional
boxSelectActivator: (event: PointerEvent) => booleanprop toSelect. The default is(event) => event.shiftKey, so existing behavior is preserved. Consumers can now opt into left-button-only or any other trigger.Checklist