add note about rate limits for letsencrypt #1080
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
with the default AutoCert configuration (letsencrypt and no cache path), it only takes five app restarts to exhaust the production letsencrypt cert issuance limit. The next restart then has to be delayed 34 hours to successfully receive a cert.
i think the existing doc comment for
cache_pathmakes it seem relatively safe to omit. i was aware of letsencrypt's pretty strict rate limits, but was expecting it to only be a couple hours if i reached it. it's not super fun to wait 1.5 days.this change balances the existing doc comment with a letsencrypt-specific note about this limit and long lockout.