Add a flow to use Zarr datasets through the Hub#83
Merged
Conversation
lmtroper
approved these changes
Mar 26, 2024
lmtroper
left a comment
Contributor
There was a problem hiding this comment.
Reviewed the changes, looks good to me!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelogs
PolarisHubClient.upload_datasetto also upload the Zarr archive if it exists.zarr_root_archiveattribute to theDataset.polaris/utils/io.pypolaris/utils/fs.pyChecklist:
Was this PR discussed in an issue? It is recommended to first discuss a new feature into a GitHub issue before opening a PR.Add tests to cover the fixed bug(s) or the newly introduced feature(s) (if appropriate).feature,fixortest(or ask a maintainer to do it for you).While we cannot do automated tests, I set up a simple test case myself:
TODO:
Dataset(or the equality test) #16PolarisFSfor Zarr files up to 10GB #74